[Codeship] fix status checking regexp & add new statuses

[zosiu]

We don't need to match the file extension to determine the status.
This should fix #1654 .

[shields-ci]

	Warnings
⚠️	This PR modified the server but none of the service tests. That's okay so long as it's refactoring existing code.

	Messages
📖	✨ Thanks for your contribution to Shields, @MikkaBouzu!

Generated by 🚫 dangerJS

[RedSparr0w]

Also note that it seems the status codes in our code may be slightly outdated:

        case 'success':
          badgeData.text[1] = 'passing';
          badgeData.colorscheme = 'brightgreen';
          break;
        case 'projectnotfound':
          badgeData.text[1] = 'not found';
          break;
        case 'branchnotfound':
          badgeData.text[1] = 'branch not found';
          break;
        case 'testing':
        case 'waiting':
          badgeData.text[1] = 'pending';
          break;
        case 'error':
          badgeData.text[1] = 'failing';
          badgeData.colorscheme = 'red';
          break;
        case 'stopped':
          badgeData.text[1] = 'not built';
          break;

from the link provided by @dennisnewel

initiated: newly started build
error: failed builds
success: passed builds
stopped: stopped builds
waiting: waiting builds
ignored: builds ignored because the account is over the monthly build limit
blocked: builds blocked because of excessive resource consumption
infrastructure_failure: builds which failed because of an internal error on the build VM

So i think it might need to be updated to something like:

        case 'success':
          badgeData.text[1] = 'passing';
          badgeData.colorscheme = 'brightgreen';
          break;
        case 'projectnotfound':
          badgeData.text[1] = 'not found';
          break;
        case 'branchnotfound':
          badgeData.text[1] = 'branch not found';
          break;
        case 'testing':
        case 'waiting':
        case 'initiated':
          badgeData.text[1] = 'pending';
          break;
        case 'error':
        case 'infrastructure_failure':
          badgeData.text[1] = 'failing';
          badgeData.colorscheme = 'red';
          break;
        case 'stopped':
        case 'ignored':
        case 'blocked':
          badgeData.text[1] = 'not built';
          break;

[RedSparr0w]

Not sure if we should set this as error or failing, what do you think is the best text to describe this?

Codeship returns error for this status maybe we should follow suit?

[zosiu]

I don't feel the need to add a new status, if there is an error with the build itself, that's a failing build all the same imo.

[RedSparr0w]

Thanks for the PR,
Changes look good to me.

Merged!
😄