Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MicroBadger] Fix tests - new attempt #1677

Merged
merged 1 commit into from
May 7, 2018
Merged

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented May 7, 2018

The stability of our MicroBadger service tests has been quite variable lately, due to temporary losses of metadata (in particular the download size) in some of the images we were using.

I opened an issue on their service repository, which they promptly resolved by doing a full refresh of their data. I haven't noticed anything unexpected since then.

Consequently, I've rearranged the tests once again, with the hope that we won't have to revisit this again in a few weeks.

  • our two"happy" image size tests use images that haven't changed in a few years, in order to minimise the risk of the data from being lost/taking too long to be refreshed when updated.
  • the "unhappy" test where no DownloadSize is present in the response is now mocked.

Note that I haven't changed the examples on the homepage, as they seem to be working fine at this point.

@shields-ci
Copy link

Messages
📖

✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS

@PyvesB PyvesB merged commit 3518b64 into badges:master May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants