add more rules to dangerfile #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedSparr0w
approved these changes
May 27, 2018
RedSparr0w
reviewed
May 27, 2018
| }); | ||
|
|
||
| all_files.forEach(function(file) { | ||
| if (/^services\/.+\/.+\.js$/.test(file) && file.endsWith('.js') && !file.endsWith('.tester.js')) { |
There was a problem hiding this comment.
You should be able to get away with just using this regex:
if (/^services\/.+\/[^\.]+(?:(?!\.tester))\.js$/.test(file)) {But the way you have it currently is more self explanatory.
There was a problem hiding this comment.
I think in this case the longer expression is more readable
platan
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
danger.jsto the latest version (includes fixes for Unexpected behaviour calling diffForFile on added or renamed file danger/danger-js#532 and diffForFile produces unexpected result if PR is made from fork danger/danger-js#531 )assert, suggestexpectsyntax (refs Add more checks to dangerfile.js #1553 ).