-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReSharper gallery badge. #1722
Conversation
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - couple of examples to add and it is good to go
previewUri: '/jetbrains/plugin/v/9630-a8translate.svg' | ||
}, | ||
{ | ||
title: 'JetBrains ReSharper Plugins', | ||
previewUri: '/resharper/v/ReSharper.Nuke.svg' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add an example for the /vpre
endpoint here and an example under the downloads section for the /dt
endpoint you've added.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorted - thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matkoch Thanks for PR. It has great tests!
I have one comment. https://plugins.jetbrains.com/ is named "JetBrains Plugins Repository" and it has plugins not only for IntelliJ IDEA, but also for PyCharm, WebStorm, Android Studio and many others. That's why I think previous name "JetBrains plugins" was better.
Well, PyCharm, WebStorm and others are all based on IntelliJ. “JetBrains plugins” is definitely more vague even wrong, because ReSharper is also a product and plugins from plugins.jetbrains.com don’t apply to it. |
@matkoch good point, merged! |
Thanks! :) When will this be live? |
@matkoch Unfortunately I cannot give you any date. Thaddée [@espadrine], who has limited time on this project, is the only sysadmin. I the past deploys usually happened every 1–3 weeks, but this changed recently and last deploy was on March 25. |
Also changed the description from 'JetBrains Plugins' to 'JetBrains IntelliJ IDEA Plugins'. Otherwise, it would be ambiguous.