Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReSharper gallery badge. #1722

Merged
merged 1 commit into from
Jun 9, 2018
Merged

Add ReSharper gallery badge. #1722

merged 1 commit into from
Jun 9, 2018

Conversation

matkoch
Copy link
Contributor

@matkoch matkoch commented Jun 5, 2018

Also changed the description from 'JetBrains Plugins' to 'JetBrains IntelliJ IDEA Plugins'. Otherwise, it would be ambiguous.

@shields-ci
Copy link

shields-ci commented Jun 5, 2018

Messages
📖

✨ Thanks for your contribution to Shields, @matkoch!

📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS

Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - couple of examples to add and it is good to go

previewUri: '/jetbrains/plugin/v/9630-a8translate.svg'
},
{
title: 'JetBrains ReSharper Plugins',
previewUri: '/resharper/v/ReSharper.Nuke.svg'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add an example for the /vpre endpoint here and an example under the downloads section for the /dt endpoint you've added.

@chris48s chris48s added the service-badge New or updated service badge label Jun 7, 2018
@matkoch
Copy link
Contributor Author

matkoch commented Jun 8, 2018

Done.

Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorted - thanks

Copy link
Member

@platan platan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matkoch Thanks for PR. It has great tests!
I have one comment. https://plugins.jetbrains.com/ is named "JetBrains Plugins Repository" and it has plugins not only for IntelliJ IDEA, but also for PyCharm, WebStorm, Android Studio and many others. That's why I think previous name "JetBrains plugins" was better.

@matkoch
Copy link
Contributor Author

matkoch commented Jun 9, 2018

Well, PyCharm, WebStorm and others are all based on IntelliJ. “JetBrains plugins” is definitely more vague even wrong, because ReSharper is also a product and plugins from plugins.jetbrains.com don’t apply to it.

@platan platan merged commit 7f9102d into badges:master Jun 9, 2018
@platan
Copy link
Member

platan commented Jun 9, 2018

@matkoch good point, merged!

@matkoch
Copy link
Contributor Author

matkoch commented Jun 9, 2018

Thanks! :) When will this be live?

@platan
Copy link
Member

platan commented Jun 10, 2018

@matkoch Unfortunately I cannot give you any date. Thaddée [@espadrine], who has limited time on this project, is the only sysadmin. I the past deploys usually happened every 1–3 weeks, but this changed recently and last deploy was on March 25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants