Rewrite [npm] typedefs badge using new-style service #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # services/base.js
# Conflicts: # lib/error-helper.js # package.json # server.js # services/appveyor/appveyor.js # services/base.js # services/errors.js
Generated by 🚫 dangerJS |
chris48s
reviewed
Jun 16, 2018
services/npm/npm.js
Outdated
| const json = await this._sendAndCacheRequest(apiUrl, { | ||
| headers: { 'Accept': '*/*' }, | ||
| }).then(checkErrorResponse.asPromise({ notFoundMessage: 'package not found' })) | ||
| .then(asJson); |
There was a problem hiding this comment.
Now that I've merged #1702 you should be able to rebase this on to master and modify this to extend BaseJsonService and replace this block with _requestJson(). Apart from that, looks good 👍
|
Thanks for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1358! Reviving some work from a few months back…