Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for github deploy #1774

Merged
merged 10 commits into from
Jul 19, 2018
Merged

Fixes for github deploy #1774

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
31111ad
Fixes for github deploy
paulmelnikow Jul 12, 2018
0d505ac
Try to fix CI build
paulmelnikow Jul 12, 2018
7709222
FIx the build
paulmelnikow Jul 12, 2018
859d480
Try to fix deploy
paulmelnikow Jul 12, 2018
de8eff0
Fix the favicon
paulmelnikow Jul 17, 2018
c0e68e4
Don’t need to build the website twice
paulmelnikow Jul 19, 2018
04bc808
For now, don’t build a new favicon
paulmelnikow Jul 19, 2018
3ba8c77
This does need `website`
paulmelnikow Jul 19, 2018
e0cae10
...ever
paulmelnikow Jul 19, 2018
76235b8
+ comment
paulmelnikow Jul 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ all: website favicon test
favicon:
node lib/badge-cli.js '' '' '#bada55' .png > favicon.png
Copy link
Member

@RedSparr0w RedSparr0w Jul 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just me, or does this no longer produce anything?
Also without the .png it produces this for me:

I presume it's supposed to make this though:

https://img.shields.io/:--bada55.png?style=plastic

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, weird. node lib/badge-cli.js '' '' '#bada55' > favicon.svg produces the right svg for me. No quotes… wonder if that could be a windows thing? Is it better if '' '' is replaced with "" "" in the makefile?

However the png is not working for me either. It makes a valid PNG but it's all gray. I upgraded imagemagick, and it changed to a different gray (!) but still isn't working correctly.

Copy link
Member Author

@paulmelnikow paulmelnikow Jul 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened a new issue: #1788. Going to just back out the favicon updating for now, since we still have a working one checked in.


website:
website: favicon
LONG_CACHE=false npm run build

deploy: website deploy-s0 deploy-s1 deploy-s2 deploy-gh-pages deploy-gh-pages-clean
Expand Down Expand Up @@ -46,6 +46,7 @@ deploy-gh-pages:
git -C ${DEPLOY_TEMP} ls-files | xargs git -C ${DEPLOY_TEMP} rm
git -C ${DEPLOY_TEMP} commit -m '[DEPLOY] Completely clean the index'
cp -r build/* ${DEPLOY_TEMP}
cp favicon.png ${DEPLOY_TEMP}
echo shields.io > ${DEPLOY_TEMP}/CNAME
Copy link
Member

@espadrine espadrine Jul 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulmelnikow The point of the CNAME file was to have GitHub redirect from badges.github.io/shields to shields.io.

I believe it no longer needs that, as it is now set up through the project settings: https://help.github.com/articles/adding-or-removing-a-custom-domain-for-your-github-pages-site/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something in my testing suggested the file still has an effect. When I ran this script on my fork without the CNAME file in gh-pages, it turned off the custom domain.

This link suggests changes made in the UI are stored in the repo: https://help.github.com/articles/troubleshooting-custom-domains/#github-repository-setup-errors

touch ${DEPLOY_TEMP}/.nojekyll
git -C ${DEPLOY_TEMP} add .
Expand Down