Start cleaning up github auth routes #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move github token debug route to separate module - Use crypto.timingSafeEqual - Rename getTokenDebugInfo -> serializeDebugInfo This picks some more of the work from #1205.
paulmelnikow
commented
Jul 27, 2018
services/github/admin.js
Outdated
| // | ||
| // e.g. | ||
| // curl -u ':very-very-secret' 'https://example.com/$github-auth/tokens' | ||
| server.ajax.on('github-auth/tokens', (json, end, ask) => { |
There was a problem hiding this comment.
This endpoint doesn't have a test. We could either add one or test this manually.
Generated by 🚫 dangerJS |
RedSparr0w
approved these changes
Aug 1, 2018
This was referenced Aug 10, 2018
paulmelnikow
added a commit
that referenced
this pull request
Aug 11, 2018
Fix regressions in the github admin and token acceptor endpoints, introduced in #1813.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks some more of the work from #1205.