Refactor [github] initialization

[paulmelnikow]

This creates a new convenience class which consolidates all the Github initialization. It supports dependency injection and facilitates refactoring the persistence along the lines of #1205.

Also ref #1848

[shields-ci]

	Warnings
⚠️	This PR modified the server but none of the service tests. That's okay so long as it's refactoring existing code.
⚠️	This PR modified helper functions in lib/ but not accompanying tests. That's okay so long as it's refactoring existing code.

	Messages
📖	✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS

[PyvesB]

Reviewed, the implementation makes sense. 👍

Should we add a few tests to github-constellation.js, to check what's going on in the initialize and stop functions?

[paulmelnikow]

Should we add a few tests to github-constellation.js, to check what's going on in the initialize and stop functions?

I’m not sure it makes sense to add any. All they could really do is mock all the method calls, and if we do that we still don’t know the code actually works. IMO it’s better to test at a lower level, with specs for persistence, the token logic, and maybe the acceptor routes, and at a higher level, to depend on the service tests making sure we can hit github.

[PyvesB]

Fair enough, let's get this merged then!

[paulmelnikow]

Thanks!

[shields-deployment]

This pull request was merged to master branch. Now this change is waiting for deployment.
Deploys usually happen every few weeks. After deployment changes are copied to gh-pages branch.

This badge displays deployment status: