Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InvalidParameter runtime error and return inaccessible for 5xx errors #1890

Merged
merged 6 commits into from
Aug 11, 2018
Merged

Add InvalidParameter runtime error and return inaccessible for 5xx errors #1890

merged 6 commits into from
Aug 11, 2018

Conversation

paulmelnikow
Copy link
Member

This came up while I was rewriting uptimerobot, which for usability reasons has some internal validation of one of its parameters.

shields/server.js

Lines 6773 to 6777 in 09be682

if (monitorApiKey.substring(0, "m".length) !== "m") {
badgeData.text[1] = 'must use a monitor key';
sendBadge(format, badgeData);
return;
}

Also it seems that the shields error message for a 5xx error is inaccessible, not invalid.

@paulmelnikow paulmelnikow added the core Server, BaseService, GitHub auth, Shared helpers label Aug 10, 2018
@shields-ci
Copy link

Messages
📖

✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS

Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@shields-deployment
Copy link

This pull request was merged to master branch. Now this change is waiting for deployment.
Deploys usually happen every few weeks. After deployment changes are copied to gh-pages branch.

This badge displays deployment status:

chris48s added a commit to chris48s/shields that referenced this pull request Aug 11, 2018
this case is covered in base class tests added in badges#1890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Server, BaseService, GitHub auth, Shared helpers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants