-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce boilerplate in a few more service testers [cdnjs continuousphp node shippable wercker gem] #1957
Conversation
… node shippable wercker] Follow up to #1934.
Generated by 🚫 dangerJS |
Looks good 👍 It looks like NPM downloads and Gem downloads also got overlooked in #1934 for some reason: shields/services/gem/gem-downloads.tester.js Lines 8 to 13 in ae190c5
shields/services/npm/npm-downloads.tester.js Lines 9 to 14 in ae190c5
was that oversight, or is there something we're waiting on for those? (like with APM) |
I thought I responded to this comment, though I don't see it now. 🤔 I updated gem-downloads. npm-downloads can't be handled using this shortcut, because that module exposes four separate services. This should be good to merge! |
Follow up to #1934.