-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static Code Climate examples #2201
Conversation
Generated by 🚫 dangerJS |
I have deployed a review app, everything seems fine apart from the static examples not showing up. Am I being thick here? 😄 |
I think if you want to use Lines 90 to 106 in 95f1b50
I've not checked if this works, but given |
@chris48s thank you for your help! This piece of work should now be ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No probs. Approach looks good, but 3 of the examples look a bit odd because the colour doesn't match with the value on the badge.
staticExample: { | ||
label: 'coverage', | ||
message: '95%', | ||
color: 'yellowgreen', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be green (or a lower value)
title: 'Code Climate coverage (letter)', | ||
exampleUrl: 'coverage-letter/jekyll/jekyll', | ||
urlPattern: 'coverage-letter/:userRepo', | ||
staticExample: { label: 'coverage', message: 'A', color: 'green' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be brightgreen (or a lower value)
staticExample: { | ||
label: 'technical debt', | ||
message: '3%', | ||
color: 'green', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should also be brightgreen (or a lower value)
You're right, I got confused with the shades of green! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorted - cheers
Nice work, hopefully this reduces the API hits a fair amount. |
We've hit a wall in #1518, our Code Climate badges have been unreliable for months now.
This pull request aims at sparing some of our limited API quota by switching to static examples on the homepage.
I'm not willing to migrate the badges to the new service architecture at this point as we've already put in quite a lot of investigation and development effort in these badges. The least we can say is that @codeclimate have not been very cooperative and have been dragging their feet since one of our users first contacted them back in April.