Improved [MicroBadger] tests speed #2512
Conversation
PyvesB
changed the title
|
It's not essential, though it'd be great if you could update the |
paulmelnikow
added
the
keep-service-tests-green
|
No tests have timed out this time round and they execute much faster with the new images, below one second. |
|
@paulmelnikow can these examples really be converted at this point? As the tag is optional, wouldn't we be affected by #2497? |
|
In examples I haven't been using optionals, so #2497 doesn't apply. Instead there's usually a different pattern for each example, one with and without the optional part. That way each example renders the way you'd expect:
|
|
I got confused with the route pattern, it's getting quite late over here. The examples should now be migrated. |
| @@ -22,22 +22,38 @@ module.exports = class MicroBadger extends LegacyService { | |||
| return [ | |||
| { | |||
| title: 'MicroBadger Size', | |||
| previewUrl: 'image-size/fedora/apache', | |||
There was a problem hiding this comment.
It looks like the patterns are missing eg image-size.
Addresses #2489. Selected images that are less "heavy" and seemed to give faster response times from the API. I also aligned the example
previewUrlsto match what was used in the test.