Fix [suggest]

[paulmelnikow]

Ref #2420 (comment)

[shields-ci]

	Warnings
⚠️	This PR modified helper functions in lib/ but not accompanying tests. That's okay so long as it's refactoring existing code.

	Messages
📖	✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against df25272

[shields-deployment]

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

[techtonik]

Is it possible to have a smoke test for this functionality?

[paulmelnikow]

It gets tested as part of the service test run. The test was failing, but hadn’t been picked up on yet.

[techtonik]

I don't see any failures in https://github.com/badges/shields/commits/master - is service test run is a manual process?

[paulmelnikow]

The full service-test run is here:

https://circleci.com/gh/badges/daily-tests

The suggest tests will be passing now because the fix is merged.

We can’t run all the tests on every commit so we run affected tests as parts of PRs. The brackets around suggest in the PR indicate that test suite ran here.

Occasionally a change will affect something unexpected so it gets caught later by the daily tests.

[techtonik]

We can’t run all the tests on every commit

Why? It is only 4 minutes in the daily log.

[paulmelnikow]

Our PR build runs in about 20 seconds; 4 minutes is much too slow. The other issue is that the service tests rely on external services. #927 is the discussion about that. We used to run the full suite on every commit to master, but stopped because they often fail for reasons outside our control. The thing we could use more help with is keeping up with fixing the failures identified tests (i.e. #1359).

[techtonik]

I see. Is there a way to make a "yellow" badge status if tests are failed because of external services and resort to "red" if there is something wrong with the code?