Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overriding bind address on CLI #2773

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Fix overriding bind address on CLI #2773

merged 1 commit into from
Jan 15, 2019

Conversation

paulmelnikow
Copy link
Member

This fixes e.g. node server 8080 0.0.0.0.

Ref #2772.

@paulmelnikow
Fix overriding bind address on CLI
8119360 
This fixes e.g. `node server 8080 0.0.0.0`.

Ref #2772.
@paulmelnikow paulmelnikow added the core Server, BaseService, GitHub auth, Shared helpers label Jan 15, 2019
@shields-ci
Copy link

Warnings
⚠️ This PR modified the server but none of its tests.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against 8119360

@paulmelnikow paulmelnikow mentioned this pull request Jan 15, 2019
Open
9 tasks
jankeromnes
jankeromnes approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bind address should indeed be a string, and not be coerced into a number like the bind port.

Looks good to me!

@paulmelnikow paulmelnikow merged commit 79af284 into master Jan 15, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the fix-bind-address branch January 15, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

@jankeromnes jankeromnes jankeromnes approved these changes

Assignees
No one assigned
Labels
core Server, BaseService, GitHub auth, Shared helpers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulmelnikow @shields-ci @jankeromnes @PyvesB