Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite [travisphpversion]; improve error message in expectBadge #3352

Merged
merged 7 commits into from
Apr 24, 2019
Merged

Rewrite [travisphpversion]; improve error message in expectBadge #3352

merged 7 commits into from
Apr 24, 2019

Conversation

paulmelnikow
Copy link
Member

The change in expectBadge prints a more helpful error when message is empty.

Ref #2863

@paulmelnikow paulmelnikow added the service-badge New or updated service badge label Apr 23, 2019
@paulmelnikow paulmelnikow mentioned this pull request Apr 23, 2019
Closed
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-3352 April 23, 2019 04:28 Inactive
@shields-ci
Copy link

shields-ci commented Apr 23, 2019 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against 8f43632

calebcartwright
calebcartwright reviewed Apr 24, 2019
View reviewed changes
core/service-test-runner/icedfrisby-shields.js
throw err
}
})
Joi.attempt(json[name], expected, `${name} mismatch:`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@calebcartwright
Copy link
Member

Do you have a tester for the redirector pending? If not I can add one

@paulmelnikow
Copy link
Member Author

Ah, nope, that'd be great!

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-3352 April 24, 2019 02:23 Inactive
@paulmelnikow paulmelnikow merged commit 051e7d0 into master Apr 24, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the travis-php-version branch April 24, 2019 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulmelnikow @shields-ci @calebcartwright