Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support other [Bugzilla] instances #3633

Merged
merged 4 commits into from
Jul 4, 2019
Merged

Support other [Bugzilla] instances #3633

merged 4 commits into from
Jul 4, 2019

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Jul 1, 2019 •
edited
Loading

As stated on Bugzilla's Twitter account:

We are not http://bugzilla.mozilla.org , we are the software they run on that site (which is also used many other places)

Bugzilla is a widely used piece of open-source software, here's a list of other projects using it. Our badges should not be single-sided, this pull request adds support for any Bugzilla instance.

@PyvesB PyvesB added the service-badge New or updated service badge label Jul 1, 2019
@shields-ci
Copy link

shields-ci commented Jul 1, 2019 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS against e07ef1c

paulmelnikow
paulmelnikow previously approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@paulmelnikow paulmelnikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up :)

Looks good! Left one question about another way of handling the URL format.

services/bugzilla/bugzilla.service.js Outdated Show resolved Hide resolved
calebcartwright
calebcartwright approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PyvesB PyvesB merged commit 77b4551 into badges:master Jul 4, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@PyvesB PyvesB mentioned this pull request Jul 14, 2019
Closed
7 tasks
@calebcartwright calebcartwright mentioned this pull request Sep 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmelnikow paulmelnikow paulmelnikow left review comments

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PyvesB @shields-ci @paulmelnikow @calebcartwright @shields-cd