Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up Redis config #3705

Merged
merged 3 commits into from
Jul 12, 2019
Merged

Fix up Redis config #3705

merged 3 commits into from
Jul 12, 2019

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Jul 12, 2019 •
edited
Loading

  • Move to private
  • Fix validation
  • Don't log the URL

Ref #3332

@paulmelnikow paulmelnikow added the core Server, BaseService, GitHub auth, Shared helpers label Jul 12, 2019
@paulmelnikow paulmelnikow added the operations Hosting, monitoring, and reliability for the production badge servers label Jul 12, 2019
@shields-ci
Copy link

Warnings
⚠️ This PR modified the server but none of its tests.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against 0310bf9

@paulmelnikow paulmelnikow mentioned this pull request Jul 12, 2019
Closed
7 tasks
calebcartwright
calebcartwright approved these changes Jul 12, 2019
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paulmelnikow paulmelnikow merged commit 65afff4 into master Jul 12, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the private-redis-config branch July 12, 2019 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
core Server, BaseService, GitHub auth, Shared helpers operations Hosting, monitoring, and reliability for the production badge servers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulmelnikow @shields-ci @calebcartwright @shields-cd