move [Nexus] server and queryOpt from route to query params #3792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
calebcartwright
commented
Jul 26, 2019
| const queryParamSchema = Joi.object({ | ||
| server: optionalUrl.required(), | ||
| queryOpt: Joi.string() | ||
| .regex(/(:(?:q|g|a|v|p|c|cn|sha1|from|count|repositoryId|e|r)=[\w-. ]+)+/i) |
There was a problem hiding this comment.
This is a stricter regex than the previous one ((:.+?)?), but is based on the query params that the two Sonatype APIs actually accept (details at the links in the above inline comments).
I can swap this back to the more lenient one if anyone has concerns with this new one
calebcartwright
commented
Jul 26, 2019
| @@ -7,34 +7,34 @@ const t = (module.exports = require('../tester').createServiceTester()) | |||
|
|
|||
| t.create('search release version valid artifact') | |||
| .timeout(15000) | |||
| .get('/r/https/oss.sonatype.org/com.google.guava/guava.json') | |||
| .get('/r/com.google/bitcoinj.json?server=https://oss.sonatype.org') | |||
There was a problem hiding this comment.
Our Nexus tests are notorious for timeout occurrences in the daily test runs. I found using this target was noticeably faster though (~1 second vs. 10-12 seconds)
paulmelnikow
approved these changes
Aug 19, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3745