Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move [Jira] hostname to query param #3990

Merged
merged 5 commits into from
Sep 16, 2019
Merged

move [Jira] hostname to query param #3990

merged 5 commits into from
Sep 16, 2019

Conversation

calebcartwright
Copy link
Member

Refs #3714

@calebcartwright calebcartwright added the service-badge New or updated service badge label Sep 13, 2019
@shields-cd shields-cd temporarily deployed to shields-staging-pr-3990 September 13, 2019 02:57 Inactive
@shields-ci
Copy link

shields-ci commented Sep 13, 2019 •
edited
Loading

Warnings
⚠️

📚 Remember to ensure any changes to config.private in services/jira/jira-issue.service.js are reflected in the server secrets documentation
Messages
📖 ✨ Thanks for your contribution to Shields, @calebcartwright!

Generated by 🚫 dangerJS against 1bd96a5

@shields-cd shields-cd temporarily deployed to shields-staging-pr-3990 September 13, 2019 03:05 Inactive
paulmelnikow
paulmelnikow previously approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@paulmelnikow paulmelnikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One q about the query param name.

services/jira/jira-issue.service.js Outdated Show resolved Hide resolved
@shields-cd shields-cd temporarily deployed to shields-staging-pr-3990 September 16, 2019 02:21 Inactive
@shields-cd shields-cd temporarily deployed to shields-staging-pr-3990 September 16, 2019 14:27 Inactive
@repo-ranger repo-ranger bot merged commit 69a57fa into master Sep 16, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@calebcartwright calebcartwright deleted the jira-url-query-param branch September 16, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmelnikow paulmelnikow paulmelnikow approved these changes

Assignees
No one assigned
Labels
service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calebcartwright @shields-ci @paulmelnikow @shields-cd