Add Flattr integration #409
Conversation
| @@ -652,6 +652,30 @@ cache(function(data, match, sendBadge, request) { | |||
| }); | |||
| })); | |||
|
|
|||
| // Flattr integration | |||
| camp.route(/^\/flattr\/(.*)\.(svg|png|gif|jpg|json)$/, | |||
There was a problem hiding this comment.
I'd like to maintain the possibility to report another metric under the flattr name. However, I need your knowledge to give an appropriate name. At first, I believed that the figure represented a number of donators, but this leads me to believe that there is a separate field for that, flattrs_user_count. What does a flattr represent? How can a user flattr a product multiple times? My research makes me think that they are monthly contributions off a fixed budget, which would make contributions a suitable name. It seems odd, since it is absolutely not proportional to the amount of money received, nor to the number of consumers, which makes it seem like an odd metric to show. I'd like to know more.
There was a problem hiding this comment.
A flattr is a donation of sorts. flattrs_user_count is how many people have done it. It seems that you can flattr something once a month.
You fill your account with a certain amount of money and then you go around and flattr things, then at the end of the month your budget is split between all of the things.
Anyway, I can't really think of any clear name that is better.
There was a problem hiding this comment.
If the figure is monthly contributions off a fixed budget, we can go with /flattr/contributions/.
|
Thanks a lot for your contributing! |
|
Hi, I like this feature, this PR is soooo old, and I'd really like to get it merged. Would you be willing to add tests and address the review comment. We'll get it in lickety-split. |
|
If anyone would like to adopt this PR, please feel free to do so: grab the branch, add more commits addressing the comments, and open a new PR referencing this one. |
paulmelnikow
added
the
on-hold
Closes #389