Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When serviceData fails validation, include the service class in the stack trace #4266

Merged
merged 2 commits into from
Oct 28, 2019
Merged

When serviceData fails validation, include the service class in the stack trace #4266

merged 2 commits into from
Oct 28, 2019

Conversation

paulmelnikow
Copy link
Member

This should make it easier to debug #3784.

@paulmelnikow
When serviceData fails validation, include the service class in the s…
83356c0 
…tack trace

This should make it easier to debug #3784.
@paulmelnikow paulmelnikow added the core Server, BaseService, GitHub auth, Shared helpers label Oct 28, 2019
@shields-cd shields-cd temporarily deployed to shields-staging-pr-4266 October 28, 2019 12:43 Inactive
@paulmelnikow paulmelnikow mentioned this pull request Oct 28, 2019
Closed
@shields-ci
Copy link

Warnings
⚠️

Found 'assert' statement added in core/base-service/base.js.
Please ensure tests are written using Chai expect syntax
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against 33f0609

calebcartwright
calebcartwright approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@paulmelnikow paulmelnikow merged commit 7e0976c into master Oct 28, 2019
@paulmelnikow paulmelnikow deleted the assertion-stack-trace branch October 28, 2019 14:33
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
core Server, BaseService, GitHub auth, Shared helpers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulmelnikow @shields-ci @calebcartwright @shields-cd