.editorconfig file to help all contributors to align to a common project standards #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect specific standards.
|
Thanks to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my experience with previous pull requests, since I was using different formatting rules, it was a bit hard to work with my IDE which kept on formatting the file based on different rules.
This basic editorconfig settings should help out with that and enable contributors to set their IDEs/Editors to use it and prevent mistakes.
For me personally the issue was with the indent set to 4 spaces for js files in my projects while in this project you use 2 spaces. And since it is a bit not standard, this should help out.
Naturally contributors would need to actually use it.