Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforce strict SSL checking for [coverity] #6886

Merged
merged 2 commits into from
Aug 12, 2021
Merged

enforce strict SSL checking for [coverity] #6886

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f23f6c
enforce strict SSL checking for [coverity]
chris48s Aug 12, 2021
92a912f
Merge branch 'master' into strictssl-coverity
repo-ranger[bot] Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions services/coverity/coverity-scan.service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,6 @@ export default class CoverityScan extends BaseJsonService {
const json = await this._requestJson({
url,
schema,
options: {
// Coverity has an issue in their certificate chain that requires
// disabling the default strict SSL check in order to call their API.
// For more information see:
// https://github.com/badges/shields/issues/3334
// https://github.com/badges/shields/pull/3336
strictSSL: false,
},
errorMessages: {
// At the moment Coverity returns an HTTP 200 with an HTML page
// displaying the text 404 when project is not found.
Expand Down