Improve CTAN error handling and fix non-svg 404 badges #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmelnikow
added a commit
to badges/shields-tests
that referenced
this pull request
Mar 31, 2017
|
After re-reading an old discussion thread (#411) I agree with @espadrine that tests should be geared toward problem detection. I do still want to push responsibility for testing from the reviewer to the contributor. However we can do that more simply than the approach I began to take. In particular we should hold off on vcr-style tests. Opened a discussion thread: #927. |
espadrine
requested changes
Apr 12, 2017
server.js
Outdated
| badgeData.text[1] = 'Unknown'; | ||
| } else { | ||
| badgeData.text[1] = license; | ||
| if (license) { |
There was a problem hiding this comment.
I'm not a big fan of implicit conversion to booleans in if / for / while statements, given that they can get counter-intuitive. Could you convert it to a check for a list, along with a check for the existence of at least one license?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #921
I started work today on some vcr-style tests. They send requests to the server, record the responses to vendor requests, and then play the vendor requests back later. The library I'm using is a little buggy. The suite isn't ready for prime time. I'll add tests as I go. Hopefully there will be a meaningful amount of coverage by the time I've gotten the library under control.
I'm very open to input: https://github.com/paulmelnikow/shields-tests
These are the CTAN tests:
https://github.com/paulmelnikow/shields-tests/blob/master/vendor/ctan/spec.js