[Github] Populate Service Test #976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webcaetano
force-pushed
the
github-service-test
branch
from
7ce8fc8 to
200ccfa
Compare
Merged
webcaetano
force-pushed
the
github-service-test
branch
3 times, most recently
from
55cd377 to
6cbc29d
Compare
|
I'll remake this soon in order to eliminate unnecessary conflicts |
webcaetano
force-pushed
the
github-service-test
branch
from
312ca3b to
6e31200
Compare
|
Remaked |
|
Hey, just wanted to say that I started reviewing this. Will hopefully finish writing comments and post them this weekend. |
|
ok, thanks |
paulmelnikow
added a commit
that referenced
this pull request
Sep 22, 2017
Work by webcaetano (cherry-picked by paulmelnikow)
|
Cherry-picked and merged via 8ec2b6b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple github service tests
Merge this PR will also auto merge #745 and #756
Related to #937