Avatar improvements #176
Merged
Avatar improvements #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maxkonovalov
commented
Jul 7, 2016
maxkonovalov
commented
- Added the possibility to show/hide avatar for a certain message cell via the decorator.
- Added avatar tap handler.
- Added avatars to photo messages in ChattoApp.
Current coverage is 64.19%@@ dev #176 diff @@
==========================================
Files 63 63
Lines 3393 3405 +12
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2180 2186 +6
- Misses 1213 1219 +6
Partials 0 0
|
|
@maxkonovalov this looks great, thank you! Just one minor thing, could you rename showsAvatar to canShowAvatar? |
|
@diegosanchezr yea sure, makes sense :) |
|
Thank you! We'll merge this as soon as we adopt these changes internally ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.