Use optional in collectionView:shouldShowMenuForItemAtIndexPath:

[raisaanjani92]

When I added new menu item for the collection view, I encountered problem in
open func collectionView(_ collectionView: UICollectionView, shouldShowMenuForItemAt indexPath: IndexPath)

There are cases where the indexpath is nil, thus trigger runtime error.

I tried to fix it by adding optional for indexPath: IndexPath.

[codecov-io]

Codecov Report

Merging #310 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
- Coverage   63.33%   63.28%   -0.06%     
==========================================
  Files          63       63              
  Lines        3516     3519       +3     
==========================================
  Hits         2227     2227              
- Misses       1289     1292       +3

Impacted Files	Coverage Δ
...Controller/BaseChatViewController+Presenters.swift	44.44% <0%> (-2.23%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2b378d...dd421e7. Read the comment docs.

[AntonPalich]

Hello @raisaanjani92. Sorry for the late response. Can I ask you to put a comment
before guard statement?

// Note: IndexPath set optional due to https://github.com/badoo/Chatto/issues/310
// Might be related: https://bugs.swift.org/browse/SR-2417

[raisaanjani92]

Done, thank you!

[Hartistic]

Seems like there could be an easier way to handle this rather than changing the optionality and creating warnings. This was done back in 2017? Perhaps time to revisit this and create a better solution? How can the nil bug be reproduced? Just asking because I am not able to reproduce this.