Move initialization of PHPhotoLibrary and PHCachingImageManager to background #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 2, 2019 14:41
… to avoid possible freezes
|
|
||
| DispatchQueue.main.async(execute: { [weak self] in | ||
| guard let self = self else { | ||
| DispatchQueue.main.async(execute: completion) |
There was a problem hiding this comment.
It's already executing on the main queue, right?
| @@ -113,7 +133,7 @@ final class PhotosInputDataProvider: NSObject, PhotosInputDataProviderProtocol, | |||
| request.handleCompletion(with: result) | |||
| } | |||
| request.cancelBlock = { [weak self] in | |||
| self?.imageManager.cancelImageRequest(requestId) | |||
| self?.imageManager?.cancelImageRequest(requestId) | |||
There was a problem hiding this comment.
Could the image manager be captured by this closure instead of self?
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
==========================================
- Coverage 59.97% 59.61% -0.37%
==========================================
Files 87 87
Lines 3945 3969 +24
==========================================
Hits 2366 2366
- Misses 1579 1603 +24
Continue to review full report at Codecov.
|
| sSelf.collectionView.reloadData() | ||
| DispatchQueue.main.async(execute: completion) | ||
| sSelf.collectionViewQueue.addTask { [weak self] (completion) in | ||
| guard let sSelf = self else { return } |
There was a problem hiding this comment.
Should a completion be called?
There was a problem hiding this comment.
It wasn't before, I decided not to change it
|
Closed as duplicate of #566 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have freezes (not deadlocks) inside PHCachingImageManager initialization. According to stach trace, it might be related to PHPhotoLibrary singleton initialization. So it was moved to background thread to avoid blocking UI.