Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resource_bundles #615

Closed
wants to merge 1 commit into from
Closed

Conversation

phatmann
Copy link
Contributor

@phatmann phatmann commented Oct 2, 2019

Fixes issue #613

@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #615 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
+ Coverage   60.59%   60.73%   +0.14%     
==========================================
  Files          92       92              
  Lines        4875     4875              
==========================================
+ Hits         2954     2961       +7     
+ Misses       1921     1914       -7
Impacted Files Coverage Δ
...hatController/BaseChatViewController+Changes.swift 89.31% <0%> (+0.38%) ⬆️
...Chat Items/TextMessages/Views/TextBubbleView.swift 86.22% <0%> (+3.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b0e5d...710bcce. Read the comment docs.

@wiruzx
Copy link
Contributor

wiruzx commented Oct 7, 2019

Hey @phatmann

Thanks a lot for the PR!

I've tried to run tests in your branch and I had a crash.

Could you please check that?

Screenshot 2019-10-07 at 09 45 28

@phatmann
Copy link
Contributor Author

My fix should have allowed resource bundles to be in framework or in test bundle. That is why tests are crashing. I am not using Chatto anymore so I cannot justify spending time to make this change. Hopefully you can do so to make the tests pass.

@wiruzx
Copy link
Contributor

wiruzx commented Jan 6, 2020

@phatmann I see, I'll try to figure it out then. Thanks a lot anyway!

@wiruzx wiruzx self-assigned this Jan 6, 2020
@wiruzx
Copy link
Contributor

wiruzx commented Oct 27, 2020

Fixed in #686

@wiruzx wiruzx closed this Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants