Do not restart camera capture when camera picker is presented #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
==========================================
- Coverage 18.04% 18.02% -0.02%
==========================================
Files 97 97
Lines 5027 5032 +5
==========================================
Hits 907 907
- Misses 4120 4125 +5
Continue to review full report at Codecov.
|
…-capture-not-stopped
wiruzx
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug that is mostly noticeable on iOS 14 that introduced camera capture indicator in the status bar.
Steps:
Actual result:
There is a green indicator in the status bar
Expected result:
There shouldn't be any indicator
The issue was that when LiveCameraCellPresenter.cameraPickerDidDisappear() is called presenter restarts camera capture. However, at that moment photos input is already hidden and camera preview cell is not visible, so we shouldn't start it.