Further cleanup of Configuration model #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idyatlov
approved these changes
Jul 31, 2024
| @@ -25,7 +22,6 @@ class TestCacheKeyFactory( | |||
| .use { | |||
| it.write(versionNameProvider.versionName) | |||
There was a problem hiding this comment.
Maybe we can remove versionNameProvider.versionName as well? The version change shouldn't trigger test cache wipeout by itself. And if the apk will change then componentCachingKey will change as well.
There was a problem hiding this comment.
The idea might've been for the cache key to depend on the version of Marathon itself, however versionName seems to always be unknown because there is no Implementation-Version: in the JAR manifest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove properties that have no effect.