Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔀 :: 프로젝트 전체 리팩토링 #2

Merged
merged 6 commits into from
May 30, 2023
Merged

🔀 :: 프로젝트 전체 리팩토링 #2

merged 6 commits into from
May 30, 2023

Conversation

baekteun
Copy link
Owner

Added

  • API별 Request 구조체
  • Dictionary로 convert할 수 있다는 protocol 추가
  • Neis 요청 URL을 build할 수 있다는 protocol 추가
  • 서브 패키지 지원 방식 ADR 작성

Changed

  • 각 파라미터로 직접 받는 것을 Request 구조체를 만들어 받도록 변경
  • API별로 protocol이 있는 것을 단일 protocol로 결합
  • Concurrency, Combine지원을 위한 패키지에서 protocol안에 API함수 정의 후 구현하는 방향이 아닌, 기본 패키지의 NeisProtocol에서 확장해서 사용하는 방식으로 변경

@baekteun baekteun added the enhancement New feature or request label May 30, 2023
@baekteun baekteun self-assigned this May 30, 2023
@baekteun baekteun linked an issue May 30, 2023 that may be closed by this pull request
프로젝트 전체 리팩토링 #1
Closed
@baekteun baekteun merged commit 4b3cdc6 into master May 30, 2023
@baekteun baekteun deleted the 1-project-entier-refactoring branch May 30, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minaje0917 minaje0917 minaje0917 approved these changes

Assignees

@baekteun baekteun

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

프로젝트 전체 리팩토링
2 participants
@baekteun @minaje0917