Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed using incorrect table name. #158

Merged

Conversation

mbaksh01
Copy link

Summary of the changes (in less than 80 chars)

  • Fixed incorrect table name when using a custom table name.

Addresses #157

Copy link

@Regenhardt Regenhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, I'd prefer if the TableSearchService just injected the TableServiceClient though instead of creating it itself, just like TablePackageDatabase does. Unless there's something I miss that might be impacted by that negatively?

@mbaksh01
Copy link
Author

Thanks for the fix, I'd prefer if the TableSearchService just injected the TableServiceClient though instead of creating it itself, just like TablePackageDatabase does. Unless there's something I miss that might be impacted by that negatively?

Is the TableServiceClient not already being injected into the TableSearchService?

@Regenhardt
Copy link

You're right, it's being injected and the TableClient is the one being created there, sorry about that.

@Regenhardt Regenhardt merged commit b3ba409 into bagetter:main Jun 25, 2024
2 checks passed
@mbaksh01 mbaksh01 deleted the bugfix/incorrect-azure-table-name branch June 26, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants