Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing 'name' field and fix typo #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

baggiponte
Copy link
Owner

addresses #4. @montanarograziano would you mind reviewing? 😊

@montanarograziano
Copy link

montanarograziano commented Jan 22, 2024

LGTM! Commands works fine now.
I was testing the just commit to run an initial commit and I noticed that pyproject-fmt and validate-pyproject where not in PATH so pre-commit fails. Running pdm add pyproject-fmt validate-pyproject seems to fix.
One last note, running just commit with the repo as it is after installing dependencies, will make ruff format fail because of missing docstrings inside the init.py of tests/ and src/. Kinda irrelevant imo, but maybe worth noticing.

@baggiponte
Copy link
Owner Author

That's something I missed, will add the two tools to the optional dependency groups. How do you find using pre-commit with tools inside your dev env? I followed @JeyDi's approach and went for that, rather than having pre-commit install the projects inside a separate venv on your system.

@montanarograziano
Copy link

Actually it's not that bad: sometimes I've ran into weird issues where a command (black for example) would behave differently when ran locally vs remote pre-commit repo.
Furthermore, this should avoid running pre-commit autoupdate, as long as pdm dependencies are fixed correctly, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants