Fix usage of fast-glob API #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
globby depends on fast-glob which introduced a breaking change in 3.3.0. Their API has been expecting an string[] for `ignore` option for awhile but in the latest version it causes a TypeError. Make sure the `ignore` option is passed an array. Fixes issues for: bahmutov/cypress-split#78 (comment)
|
Super. Thanks for submitting a fix. I will look at this later today Sent from my iPhoneOn Jul 11, 2023, at 09:41, Sam Tsai ***@***.***> wrote:globby depends on fast-glob which introduced a breaking change in 3.3.0. Their API has been expecting an string[] for ignore option for awhile but in the latest version it causes a TypeError. Make sure the ignore option is passed an array.
Fixes issues for: bahmutov/cypress-split#78 (comment)
You can view, comment on, or merge this pull request online at:
#167
Commit Summary
935781c Fix usage of fast-glob API
File Changes (1 file)
M
src/index.js
(4)
Patch Links:
https://github.com/bahmutov/find-cypress-specs/pull/167.patch
https://github.com/bahmutov/find-cypress-specs/pull/167.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Thank you, closing in favor of #168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globby depends on fast-glob which introduced a breaking change in 3.3.0. Their API has been expecting an string[] for
ignoreoption for awhile but in the latest version it causes a TypeError. Make sure theignoreoption is passed an array.Fixes issues for: bahmutov/cypress-split#78 (comment)