feat: support attr inherit #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meixg
reviewed
Dec 16, 2023
src/runtime/underscore.ts
Outdated
| * @param attrs 上层透传接收的属性 | ||
| * @param props 传递的props | ||
| */ | ||
| function deleteAttrByProps (attrs: string[], props: Record<string, number>) { |
errorrik
reviewed
Jan 15, 2024
src/ast/renderer-ast-dfn.ts
Outdated
| @@ -318,7 +318,7 @@ export class HelperCall implements SyntaxNode { | |||
| public readonly kind = SyntaxKind.HelperCall | |||
| constructor ( | |||
| public name: 'styleFilter' | 'classFilter' | 'xstyleFilter' | 'xclassFilter' | 'attrFilter' | 'boolAttrFilter' | | |||
| 'output' | 'escapeHTML', | |||
| 'output' | 'escapeHTML' | 'deleteAttrByProps' | 'mergeAttr', | |||
There was a problem hiding this comment.
这里没有删干净 'deleteAttrByProps' | 'mergeAttr'
src/runtime/underscore.ts
Outdated
| @@ -16,6 +16,11 @@ export interface Context { | |||
| instance: any | |||
| } | |||
|
|
|||
| interface NewAttr { | |||
| if (Object.keys(propsAttrAssign).length) { | ||
| rootAttrExec.push(...[ | ||
| DEF('propsAttr', new MapLiteral(Object.keys(propsAttrAssign).map(name => [I(name), I('1')]))), | ||
| new Foreach(I('key'), I('val'), I('attrs'), [ |
|
🎉 This PR is included in version 3.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
wunci
pushed a commit
to wunci/san-ssr
that referenced
this pull request
Jan 26, 2024
# [3.14.0](baidu/san-ssr@nv3.13.3...nv3.14.0) (2024-01-23) ### Features * support attr inherit ([baidu#170](baidu#170)) ([221c90b](baidu@221c90b)) * support attr inherit ([baidu#171](baidu#171)) ([5ddd882](baidu@5ddd882))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
baidu/san#772