Change safemode threshold to 0.3(#1311) #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvxiang
approved these changes
Aug 21, 2017
|
LGTM |
| @@ -121,7 +121,7 @@ DEFINE_double(tera_master_load_balance_size_ratio_trigger, 1.2, "ratio of heavie | |||
| DEFINE_int32(tera_master_load_balance_ts_load_threshold, 5000, "threshold of one tabletnode in QPS load-balance decision"); | |||
| DEFINE_int32(tera_master_load_balance_scan_weight, 300, "scan weight in load-balance decision"); | |||
|
|
|||
| DEFINE_double(tera_safemode_tablet_locality_ratio, 0.9, "the tablet locality ratio threshold of safemode"); | |||
| DEFINE_double(tera_safemode_tablet_locality_ratio, 0.3, "the tablet locality ratio threshold of safemode"); | |||
There was a problem hiding this comment.
不是所有集群都设置这个值，调低了对之前的监控会失效；
感觉show集群的时候，显示集群进入safemode跟友好一点；
There was a problem hiding this comment.
这是个默认值，给初学者使用的，所有生产集群都不应直接使用这个值，而是根据实际配置。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.