-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Projectile Size with AoE #1280
Draft
Alexthw46
wants to merge
382
commits into
baileyholl:1.20
Choose a base branch
from
Alexthw46:projectile-size-test
base: 1.20
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix smelt sensitive, allow wololo to process items * Restore DyeRecipeDatagen
…aileyholl#1393) * fix: change imbuement tile to use assemble instead of getResultItem * fix: use IImbuementRecipe everywhere
* delete datagen cache from repo * add datagen cache to gitignore
Co-authored-by: Bailey Hollingsworth <baileyholl@gmail.com>
…leyholl#1560) Co-authored-by: Bailey Hollingsworth <baileyholl@gmail.com>
…ileyholl#1557) * fix: alakarkinos cold ruins conversion uses warm ruins loot table * run datagen
this issue was caused by ars_nouveau.tier changing from "Tier %s" to "Tier" some time ago. This commit rolls that change back, but since the new definition is used in GlyphProcessor, it adds ars_nouveau.spell_tier for that use case.
…on non-head side (baileyholl#1561) * fix: alteration table breaks when "OTHER" part receives shape update on non-head side * Revert "fix: alteration table breaks when "OTHER" part receives shape update on non-head side" This reverts commit 147d7d5. * fix it in a different way
starby stacking breaks when done far from 0, 0 (presumably if not loaded) also makes it so the new starby tries to ride the topmost starby or fails the interaction if it cant.
* feat: add parameterised tier display * feat: add basic tier rendering for AlterationTableRenderer * feat: center tier renderer * fix: update item positioning and fix component label --------- Co-authored-by: Darshan Phaldesai <dev.darshanphaldesai@gmail.com>
) Fixes horizontal portals getting destroyed by block updates and horizontal portal generation. Horizontal portals will no longer break when receiving a block update. Horizontal portals can now be generated by throwing the scroll anywhere inside the frame and not just on the northernmost line of blocks.
* feat: SourceUtil multi-provider take allows SourceUtil#takeSource to extract from multiple ISpecialSourceProviders in order to reach the desired amount. Also short circuits if a Creative Source Jar is found. * rename multi-provider take functions and restore single-provider takes for backwards compat * reorder methods * convert internal usages of SourceUtil to use multi-provider take and don't break when needed < 0 * deprecate single-provider takes * rename potentialRefunds to takenFrom for clarity * fix typo in comment * short circuit faster if needed <= 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.