feat: amethyst golem tweaks #1545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes the golems not respect claims - current behaviour causes them to drop the items but not break the block which results in an unintentional buff. also changes their harvesting behaviour: if they do not have a home (not sure if even possible) or their home is not an inventory, they will drop the drops as item entities. if they do have a home and it is an inventory, they will insert the dropped items directly into the home if there is free space or skip harvesting the cluster otherwise. it will continue trying other clusters in the latter case.
This comment was marked as outdated.
This comment was marked as outdated.
baileyholl
reviewed
Feb 8, 2025
| level.addFreshEntity(new ItemEntity(level, pos.getX(), pos.getY(), pos.getZ(), drop)); | ||
| } | ||
| } else { | ||
| IItemHandler iItemHandler = golem.level.getCapability(Capabilities.ItemHandler.BLOCK, golem.getHome(), null); |
There was a problem hiding this comment.
This itemstack logic to insert or drop is handled by InventoryManager
There was a problem hiding this comment.
slightly different semantics here, we want to insert the full stack or do nothing at all, unless the golem has no home or isnt allowed to access its home
baileyholl
reviewed
Feb 8, 2025
.../java/com/hollingsworth/arsnouveau/common/entity/goal/amethyst_golem/HarvestClusterGoal.java
Outdated
Show resolved
Hide resolved
baileyholl
reviewed
Feb 8, 2025
src/main/java/com/hollingsworth/arsnouveau/common/entity/AmethystGolem.java
Outdated
Show resolved
Hide resolved
baileyholl
reviewed
Feb 22, 2025
.../java/com/hollingsworth/arsnouveau/common/entity/goal/amethyst_golem/ConvertBuddingGoal.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes the golems not respect claims - current behaviour causes them to drop the items but not break the block which results in an unintentional buff.
also changes their harvesting behaviour:
if they do not have a home (not sure if even possible) or their home is not an inventory, they will drop the drops as item entities.
if they do have a home and it is an inventory, they will insert the dropped items directly into the home if there is free space or skip harvesting the cluster otherwise. it will continue trying other clusters in the latter case.