Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreadable fields with dark mode #190

Closed
infra-monkey opened this issue Feb 23, 2022 · 5 comments
Closed

Unreadable fields with dark mode #190

infra-monkey opened this issue Feb 23, 2022 · 5 comments
Assignees
@baimard
Labels
bug Something isn't working Done need tests good first issue Good for newcomers

Comments

@infra-monkey
Copy link

infra-monkey commented Feb 23, 2022 •
edited
Loading

Describe the bug
If the dark mode is enabled on nextcloud, the first field for each page is unreadable.

To Reproduce
Steps to reproduce the behavior:

  1. enable dark mode
  2. go to the customers or quotes page
  3. The first column's fields are unreadable

Expected behavior
The page should use the defined backgroud colors and text colors (or shades of them if needed) so it stays consistent with the applied theme.

Screenshots
Screenshot_gestion

Screenshot_gestion2

Desktop (please complete the following information):

  • OS: Linux Fedora 35
  • Browser: Brave 1.35.103 / Firefox 97.0
  • Version: Gestion 2.0.5
@infra-monkey
Copy link
Author

That being said, this is a nice app for freelancers or small companies

@baimard baimard self-assigned this Feb 23, 2022
@baimard baimard added bug Something isn't working good first issue Good for newcomers labels Feb 23, 2022
@baimard
Copy link
Owner

baimard commented Feb 23, 2022

thank you for reporting, I will fix that !

@infra-monkey
Copy link
Author

thank you for reporting, I will fix that !

Thank you for makeing the app and reacting so quickly 😄

baimard added a commit that referenced this issue Mar 11, 2022
@baimard
#190 #194
3019c9d
baimard added a commit that referenced this issue Mar 11, 2022
@baimard
#190 #194
f80b24d
baimard added a commit that referenced this issue Mar 11, 2022
@baimard @vitormattos
@nextcloud-bot @rakekniven @Valdnet
2.0.7 (#203)
4048f47 
* refactoring

* refactoring

refactoring

refactoring & #46

Create help section for configuration and #47 #61

changelog

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* transifex

* transifex

* test

* Translation

* translation

* hotfix

* #123

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* #135

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* valide

* valide

* final

* Final

* Final

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* [tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* l10n: Fixed grammar

Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

* l10n: Improve styling

A more selected description of the function setting.

* l10n: Improve styling 

A more selected description of the function setting.

* l10n: Add "an"

* l10n: Add "an"

* l10n: Replace a word

* l10n: Replace a word

* [tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* valide

* valide

* final

* Final

* Final

* Hotfix 2.0.2

* Hotfix 2.0.3

* enhancement tests !

* #143

* Postgresql

* NPM UPDATE

* #168

* #167

* #163

* #158

* #160

* #173

* Bug in configuration and delete confirmation message

* #142

* 2.0.5

* tests

* #53

#111

* #147

* test

* tests

* test

* test

* tests

* tests

* test

* for quote #179

* 2.0.6

* pgsql

* fix length

* #154 && refactoring pur js

* refactoring jquery

* #190 #194

* #190 #194

* #194

* test protocole

* Test OK

* Fix after tests

Co-authored-by: Vitor Mattos <vitor@php.rio>
Co-authored-by: Nextcloud bot <bot@nextcloud.com>
Co-authored-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Co-authored-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
@baimard baimard closed this as completed Mar 12, 2022
@infra-monkey
Copy link
Author

Indeed, it is fixed with 2.0.7.
Looks reallly good

@baimard
Copy link
Owner

baimard commented Mar 14, 2022

:)

baimard added a commit that referenced this issue Mar 15, 2022
@baimard @vitormattos
@nextcloud-bot @rakekniven @Valdnet
2.0.8 (#207)
da3670a 
* refactoring

* refactoring

refactoring

refactoring & #46

Create help section for configuration and #47 #61

changelog

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* transifex

* transifex

* test

* Translation

* translation

* hotfix

* #123

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* #135

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* valide

* valide

* final

* Final

* Final

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* [tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* l10n: Fixed grammar

Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

* l10n: Improve styling

A more selected description of the function setting.

* l10n: Improve styling 

A more selected description of the function setting.

* l10n: Add "an"

* l10n: Add "an"

* l10n: Replace a word

* l10n: Replace a word

* [tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* valide

* valide

* final

* Final

* Final

* Hotfix 2.0.2

* Hotfix 2.0.3

* enhancement tests !

* #143

* Postgresql

* NPM UPDATE

* #168

* #167

* #163

* #158

* #160

* #173

* Bug in configuration and delete confirmation message

* #142

* 2.0.5

* tests

* #53

#111

* #147

* test

* tests

* test

* test

* tests

* tests

* test

* for quote #179

* 2.0.6

* pgsql

* fix length

* #154 && refactoring pur js

* refactoring jquery

* #190 #194

* #190 #194

* #194

* test protocole

* Test OK

* Fix after tests

* #206 and jquery remove

* hotfix 2.0.8

Co-authored-by: Vitor Mattos <vitor@php.rio>
Co-authored-by: Nextcloud bot <bot@nextcloud.com>
Co-authored-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Co-authored-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
baimard added a commit that referenced this issue Mar 16, 2022
@baimard @vitormattos
@nextcloud-bot @rakekniven @Valdnet
2.0.8 (#212)
6625016 
* refactoring

* refactoring

refactoring

refactoring & #46

Create help section for configuration and #47 #61

changelog

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* transifex

* transifex

* test

* Translation

* translation

* hotfix

* #123

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* #135

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* valide

* valide

* final

* Final

* Final

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* [tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* l10n: Fixed grammar

Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

* l10n: Improve styling

A more selected description of the function setting.

* l10n: Improve styling 

A more selected description of the function setting.

* l10n: Add "an"

* l10n: Add "an"

* l10n: Replace a word

* l10n: Replace a word

* [tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* valide

* valide

* final

* Final

* Final

* Hotfix 2.0.2

* Hotfix 2.0.3

* enhancement tests !

* #143

* Postgresql

* NPM UPDATE

* #168

* #167

* #163

* #158

* #160

* #173

* Bug in configuration and delete confirmation message

* #142

* 2.0.5

* tests

* #53

#111

* #147

* test

* tests

* test

* test

* tests

* tests

* test

* for quote #179

* 2.0.6

* pgsql

* fix length

* #154 && refactoring pur js

* refactoring jquery

* #190 #194

* #190 #194

* #194

* test protocole

* Test OK

* Fix after tests

* #206 and jquery remove

* hotfix 2.0.8

* 2.0.8 Appinfo

Co-authored-by: Vitor Mattos <vitor@php.rio>
Co-authored-by: Nextcloud bot <bot@nextcloud.com>
Co-authored-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Co-authored-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baimard baimard

Labels
bug Something isn't working Done need tests good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@baimard @infra-monkey