-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fategrandorder.svg icon #22
Open
theokrueger
wants to merge
2
commits into
baitmooth:main
Choose a base branch
from
theokrueger:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdehenne
added a commit
to rdehenne/snow
that referenced
this pull request
Dec 18, 2024
Rework old PR baitmooth#22 from theokrueger Co-authored-by: theokrueger <theokrueger@airmail.cc>
rdehenne
added a commit
to rdehenne/snow
that referenced
this pull request
Dec 27, 2024
- Add icons for Cheque-Vacances, Banxo, Fate Grand Order (PR baitmooth#22), Fil Bleu, France Travail *, Geovelo, IDF Mobilites, Karbon, Kvaesitso, Molly, Nintendo Music, Nintendo Switch Online, Package Manager, Privacy Friendly Notes, TagMo, TBM, TGV Inoui Pro, Yelo. - Update and fix icon for BoursoBank (former Boursorama Banque) and SNCF Connect (former oui.sncf). - Update icon for Discord. - Add existing icons to multiple camera apps. - Fix icons for /e/ OS apps, Blokada, DetoxDroid (baitmooth#19), Lawnchair (baitmooth#19), OpenFoodFacts, Organic Maps (baitmooth#19).
rdehenne
added a commit
to rdehenne/snow
that referenced
this pull request
Dec 27, 2024
- Add icons for Cheque-Vacances, Banxo, Fate Grand Order (PR baitmooth#22), Fil Bleu, France Travail *, Geovelo, IDF Mobilites, Karbon, Kvaesitso, Molly, Nintendo Music, Nintendo Switch Online, Package Manager, Privacy Friendly Notes, TagMo, TBM, TGV Inoui Pro, Yelo. - Update and fix icon for BoursoBank (former Boursorama Banque) and SNCF Connect (former oui.sncf). - Update icon for Discord. - Add existing icons to multiple camera apps. - Fix icons for /e/ OS apps, Blokada, DetoxDroid (baitmooth#19), Lawnchair (baitmooth#19), OpenFoodFacts, Organic Maps (baitmooth#19).
rdehenne
added a commit
to rdehenne/snow
that referenced
this pull request
Dec 29, 2024
- Add icons for Cheque-Vacances, Banxo, Fate Grand Order (PR baitmooth#22), Fil Bleu, France Travail *, Geovelo, IDF Mobilites, Karbon, Kvaesitso, Molly, Naolib, Nintendo Music, Nintendo Switch Online, Package Manager, Privacy Friendly Notes, Resabus, TAD IDFM, TagMo, Tao, TBM, TGV Inoui Pro, Yelo. - Update and fix icon for BoursoBank (former Boursorama Banque) and SNCF Connect (former oui.sncf). - Update icon for Discord. - Add existing icons to multiple camera apps. - Fix icons for /e/ OS apps, Blokada, DetoxDroid (baitmooth#19), Lawnchair (baitmooth#19), OpenFoodFacts, Organic Maps (baitmooth#19).
rdehenne
added a commit
to rdehenne/snow
that referenced
this pull request
Dec 29, 2024
- Add icons for Cheque-Vacances, Banxo, Fate Grand Order (PR baitmooth#22), Fil Bleu, France Travail *, Geovelo, IDF Mobilites, Karbon, Kvaesitso, Molly, Naolib, Nintendo Music, Nintendo Switch Online, Package Manager, Privacy Friendly Notes, Resabus, TAD IDFM, TagMo, Tao, TBM, TGV Inoui Pro, Yelo. - Update and fix icon for BoursoBank (former Boursorama Banque) and SNCF Connect (former oui.sncf). - Update icon for Discord. - Add existing icons to multiple camera apps. - Fix icons for /e/ OS apps, Blokada, DetoxDroid (baitmooth#19), Lawnchair (baitmooth#19), OpenFoodFacts, Organic Maps (baitmooth#19).
rdehenne
added a commit
to rdehenne/snow
that referenced
this pull request
Dec 29, 2024
- Add icons for Cheque-Vacances, Banxo, Fate Grand Order (PR baitmooth#22), Fil Bleu, France Travail *, Geovelo, IDF Mobilites, Karbon, Kvaesitso, Molly, Naolib, Nintendo Music, Nintendo Switch Online, Package Manager, Privacy Friendly Notes, Resabus, TAD IDFM, TagMo, Tao, TBM, TGV Inoui Pro, Yelo. - Update and fix icon for BoursoBank (former Boursorama Banque) and SNCF Connect (former oui.sncf). - Update icon for Discord. - Add existing icons to multiple camera apps. - Fix icons for /e/ OS apps, Blokada, DetoxDroid (baitmooth#19), Lawnchair (baitmooth#19), OpenFoodFacts, Organic Maps (baitmooth#19).
rdehenne
added a commit
to rdehenne/snow
that referenced
this pull request
Dec 29, 2024
- Add icons for Cheque-Vacances, Banxo, Fate Grand Order (PR baitmooth#22), Fil Bleu, France Travail *, Geovelo, IDF Mobilites, Karbon, Kvaesitso, Molly, Naolib, Nintendo Music, Nintendo Switch Online, Package Manager, Privacy Friendly Notes, Resabus, TAD IDFM, TagMo, Tao, TBM, TGV Inoui Pro, Yelo. - Update and fix icon for BoursoBank (former Boursorama Banque) and SNCF Connect (former oui.sncf). - Update icon for Discord. - Add existing icons to multiple camera apps. - Fix icons for /e/ OS apps, Blokada, DetoxDroid (baitmooth#19), Lawnchair (baitmooth#19), OpenFoodFacts, Organic Maps (baitmooth#19).
rdehenne
added a commit
to rdehenne/snow
that referenced
this pull request
Dec 29, 2024
- Add icons for Cheque-Vacances, Banxo, Fate Grand Order (PR baitmooth#22), Fil Bleu, France Travail *, Geovelo, IDF Mobilites, Karbon, Kvaesitso, Molly, Naolib, Nintendo Music, Nintendo Switch Online, Package Manager, Privacy Friendly Notes, Resabus, TAD IDFM, TagMo, Tao, TBM, TGV Inoui Pro, Yelo. - Update and fix icon for BoursoBank (former Boursorama Banque) and SNCF Connect (former oui.sncf). - Update icon for Discord. - Add existing icons to multiple camera apps. - Fix icons for /e/ OS apps, Blokada, DetoxDroid (baitmooth#19), Lawnchair (baitmooth#19), OpenFoodFacts, Organic Maps (baitmooth#19).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComponentInfo for EN and JP apps (also added to the
appfilter.xml
):JP:
com.aniplex.fategrandorder/jp.delightworks.Fgo.player.AndroidPlugin
EN:
com.aniplex.fategrandorder.en/jp.delightworks.Fgo.player.AndroidPlugin
preview of icon
reference image
Here is the unscrubbed original file in case you need to make minor edits:
fategrandorder-unscrubbed.svg
fategrandorder-unscrubbed-recentered.svg
yeah yeah, not a FOSS app. whatever. I tried my best to follow the contributing READMEs while making this.
note that while designing the icon, I based it off the actual logo for the game, and so the thickness of the lines is not the suggested 1px, but a more true to the actual logo thickness. (I tried it with 1px and/or rounded lines and it looked very wrong).
Also, if there were build instructions for this, that would be great because I cannot figure out intuitively how to incorporate any new icons.