-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How can "toggle" be set to true as default? #17
Comments
Just added this! Set |
Very nice!
|
Didn't even think to expand this to the other setting types, will do. |
I'm rethinking this actually, since this package's goal isn't to handle the settings themselves in your app, just make a nice gui for them in Nova. With the toggle for example, setting @michapixel thoughts? |
My standpoint would be:
Not all settings possible should be covered by this tool, but the most
basic things, like checkbox/toggle, input (single line), input numbers (int
and decimal), Multiline text, image field, icon field (fontawesome,
customizable?)
And for complex one's I'd suggest json-editor (
https://github.com/josdejong/jsoneditor/blob/develop/README.md)
Beware, I'm on vacation this week and the next, and after that i might be
working on some other thing the first days, but I'll try to help, as i
think this might be very handsome in every project.
Let me know what you think.
Jacob Baker-Kretzmar <notifications@github.com> schrieb am Sa., 27. Juli
2019, 21:38:
… I'm rethinking this actually, since this package's goal isn't to handle
the settings themselves in your app, just make a nice gui for them in Nova.
With the toggle for example, setting default => true actually *doesn't
affect the value of the setting in the JSON*, only what gets displayed on
the tool. This actually strikes me as pretty confusing.
@michapixel <https://github.com/michapixel> thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17?email_source=notifications&email_token=AAC2RPIIYKQWNPYWEKB6MW3QBSP3VA5CNFSM4HXKJLTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD26RMAI#issuecomment-515708417>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC2RPNRQHOWJ4YLTEJDNOLQBSP3VANCNFSM4HXKJLTA>
.
|
@michapixel thanks for your input. I'm going to revert this in v1, I think it's safer to keep the presentation of the settings and their values firmly separate, if a setting needs to be 'on' or some other value by default, you should configure that where you're consuming the setting value or just manually set it to your desired default when you add it. |
No description provided.
The text was updated successfully, but these errors were encountered: