Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow custom hostnames setting for db, elastic, rabbit with envvar #554

Merged
merged 3 commits into from
Mar 20, 2021

Conversation

nicolasochem
Copy link
Contributor

You can not always assume the hostname of the remote services.

For example, in tezos-k8s, I am running everything in a pod, so
I need to set everything to localhost.

In order to not disrupt any existing workflow, we set these env
vars to standard values in the Dockerfile; they can be overridden
at runtime. See: https://stackoverflow.com/a/40334819/207209

You can not always assume the hostname of the remote services.

For example, in tezos-k8s, I am running everything in a pod, so
I need to set everything to `localhost`.

In order to not disrupt any existing workflow, we set these env
vars to standard values in the Dockerfile; they can be overridden
at runtime. See: https://stackoverflow.com/a/40334819/207209
@aopoltorzhicky
Copy link
Member

Hi, thanx for pull. Seems like you skip dockerfile of others our services e.g. metrics, compiler etc. But I think it will be better use default env in docker-compose instead of adding layers in dockerfile. Something like that: key: ${ENVVAR:-defaultvalue}

@nicolasochem
Copy link
Contributor Author

thanks @aopoltorzhicky , this is indeed better. I pushed the changes as requested.

configs/production.yml Outdated Show resolved Hide resolved
@m-kus m-kus merged commit 80eeff9 into baking-bad:master Mar 20, 2021
nicolasochem added a commit to nicolasochem/tezos-k8s that referenced this pull request Mar 24, 2021
Both indexers are able to index a private chain.

BCD indexer needs private images with env variables to set the hostname for elastic/db/rabbitmq. Next release of BCD hub will have them, until then it is necessary to build your own containers:

baking-bad/bcdhub#554

The indexer need to be activated in values.yaml and does not run by default. The default values.yaml has an explanation in comments.
TristanAllaire pushed a commit to mavryk-network/bcdhub that referenced this pull request Apr 29, 2024
* Feature: hex viewer

* Fix: html injection

* Remove commented code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants