Code smells

baking-bad · Mar 14, 2023 · 884a2bc · 884a2bc
1 parent 494b6f1
commit 884a2bc
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/Tzkt.Api/Parameters/ManagerOperationFilter.cs b/Tzkt.Api/Parameters/ManagerOperationFilter.cs
@@ -57,7 +57,7 @@ public class ManagerOperationFilter : INormalizable
             status == null &&
             sender == null;
 
-        public virtual string Normalize(string prop)
+        public virtual string Normalize(string name)
         {
             return ResponseCacheService.BuildKey("",
                 ("id", id), ("hash", hash), ("counter", counter), ("level", level),

diff --git a/Tzkt.Api/Parameters/SrOperationFilter.cs b/Tzkt.Api/Parameters/SrOperationFilter.cs
@@ -12,7 +12,7 @@ public class SrOperationFilter : ManagerOperationFilter
 
         public override bool Empty => base.Empty && rollup == null;
 
-        public override string Normalize(string prop)
+        public override string Normalize(string name)
         {
             return ResponseCacheService.BuildKey("",
                 ("id", id), ("hash", hash), ("counter", counter), ("level", level),

diff --git a/Tzkt.Api/Parameters/SrRecoverBondOperationFilter.cs b/Tzkt.Api/Parameters/SrRecoverBondOperationFilter.cs
@@ -20,7 +20,7 @@ public class SrRecoverBondOperationFilter : SrOperationFilter
 
         public override bool Empty => base.Empty && staker == null && anyof == null;
 
-        public override string Normalize(string prop)
+        public override string Normalize(string name)
         {
             return ResponseCacheService.BuildKey("",
                 ("id", id), ("hash", hash), ("counter", counter), ("level", level),

diff --git a/Tzkt.Sync/Services/Cache/RefutationGameCache.cs b/Tzkt.Sync/Services/Cache/RefutationGameCache.cs
@@ -38,7 +38,7 @@ public void Trim()
             {
                 var toRemove = CachedByKey.Values
                     .OrderBy(x => x.LastLevel)
-                    .Take(MaxItems / 2)
+                    .Take(CachedByKey.Count - (int)(MaxItems * 0.75))
                     .ToList();
 
                 foreach (var item in toRemove)

diff --git a/Tzkt.Sync/Services/Cache/SmartRollupCommitmentCache.cs b/Tzkt.Sync/Services/Cache/SmartRollupCommitmentCache.cs
@@ -36,7 +36,7 @@ public void Trim()
             {
                 var toRemove = CachedByKey.Values
                     .OrderBy(x => x.LastLevel)
-                    .Take(MaxItems / 2)
+                    .Take(CachedByKey.Count - (int)(MaxItems * 0.75))
                     .ToList();
 
                 foreach (var item in toRemove)

diff --git a/Tzkt.Sync/Services/Cache/SmartRollupStakesCache.cs b/Tzkt.Sync/Services/Cache/SmartRollupStakesCache.cs
@@ -35,7 +35,7 @@ public void Remove(int commitmentId, int stakerId)
 
         public void Trim()
         {
-            if (Cache.Count > Cache.Count)
+            if (Cache.Count > MaxItems)
             {
                 var toRemove = Cache.Keys
                     .OrderBy(x => x)