Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket - cycles events #120

Merged
merged 12 commits into from
Jul 25, 2022
Merged

Websocket - cycles events #120

merged 12 commits into from
Jul 25, 2022

Conversation

cryi
Copy link
Contributor

@cryi cryi commented Jul 24, 2022

Adds SubscribeToCycle. Meant to be used in tools like Breadcrumbs where head updates are unnecessary.

@cryi
Copy link
Contributor Author

cryi commented Jul 24, 2022

Hey @Groxan,
I just realized that for our use case it does make sense only report completed cycles. It is easy to change this to completed cycles but I wonder you can see some use case where it makes sense to report cycle which is in progress. If so should I create separate processor or report both completed cycle and new cycle or switch through parameter.

Nvm, there are not that important data in the Cycle anyway. We will just fetch needed data when notified. So from our side this is ok.

@cryi cryi changed the title WIP: Websocket - cycle events Websocket - cycles events Jul 24, 2022
@cryi
Copy link
Contributor Author

cryi commented Jul 24, 2022

Tested on ghostnet. All good.

@Groxan Groxan merged commit f9ec301 into baking-bad:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants