Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose 5000 in Dockerfile and secure postgresql database #79

Merged
merged 2 commits into from
Dec 28, 2021

Conversation

jpic
Copy link
Contributor

@jpic jpic commented Dec 24, 2021

No description provided.

This makes the image usable in GitLab-CI services.
@m-kus
Copy link
Member

m-kus commented Dec 24, 2021

Hey! Thanks for contribution💪🏻
Can you please modify you PR a bit:

  • let db service be exposed at 127.0.0.1:5432 for debugging purposes
  • use ${POSTGRES_PASSWORD:-qwerty} ${POSTGRES_USER:-tzkt} and ${POSTGRES_DB:-tzkt} both in connection strings and db container envs

@m-kus
Copy link
Member

m-kus commented Dec 24, 2021

*Edited

@Groxan
Copy link
Member

Groxan commented Dec 28, 2021

Hey! Thank you for your contribution!

@Groxan Groxan merged commit c3168cb into baking-bad:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants