Merge pull request #349 from beethovenxfi/daniel/configurable-connect…

…ing-tokens Small adjustments to configurable-connecting-tokens
balancer · Jan 25, 2023 · c3e0f98 · c3e0f98
2 parents 7c9a22d + bdf30c0
commit c3e0f98
Showing 1 changed file with 13 additions and 10 deletions.
diff --git a/src/routeProposal/filtering.ts b/src/routeProposal/filtering.ts
@@ -176,6 +176,9 @@ export function getBoostedGraph(
     const graphPoolsSet: Set<PoolBase> = new Set();
     const linearPools: PoolBase[] = [];
     const phantomPools: PoolBase[] = [];
+    const connectingTokens = config.connectingTokens.map(
+        (connectingToken) => connectingToken.address
+    );
     // Here we add all linear pools, take note of phantom pools,
     // add LBP pools with tokenIn or tokenOut and their corresponding
     // highest liquidity WETH connections
@@ -194,9 +197,6 @@ export function getBoostedGraph(
                 phantomPools.push(pool);
             }
             if (config.lbpRaisingTokens && pool.isLBP) {
-                const connectingTokens = config.connectingTokens.map(
-                    (connectingToken) => connectingToken.address
-                );
                 handleLBPCase(
                     graphPoolsSet,
                     config.lbpRaisingTokens,
@@ -211,21 +211,24 @@ export function getBoostedGraph(
     }
     // add best pools tokenIn -> connectingToken and connectingToken -> tokenOut
     for (const connectingToken of config.connectingTokens) {
-        const bestTokenInToConnectingToken = getHighestLiquidityPool(
+        const bestTokenInToConnectingTokenPoolId = getHighestLiquidityPool(
             tokenIn,
             connectingToken.address,
             poolsAllDict
         );
-        if (bestTokenInToConnectingToken) {
-            graphPoolsSet.add(poolsAllDict[bestTokenInToConnectingToken]);
-        }
-        const bestConnectingTokenToTokenOut = getHighestLiquidityPool(
+        const bestConnectingTokenToTokenOutPoolId = getHighestLiquidityPool(
             connectingToken.address,
             tokenOut,
             poolsAllDict
         );
-        if (bestConnectingTokenToTokenOut) {
-            graphPoolsSet.add(poolsAllDict[bestConnectingTokenToTokenOut]);
+        if (
+            bestTokenInToConnectingTokenPoolId &&
+            bestConnectingTokenToTokenOutPoolId
+        ) {
+            graphPoolsSet.add(poolsAllDict[bestTokenInToConnectingTokenPoolId]);
+            graphPoolsSet.add(
+                poolsAllDict[bestConnectingTokenToTokenOutPoolId]
+            );
         }
     }
     if (linearPools.length == 0) return {};