Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper type to match Swaps. #369

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Add proper type to match Swaps. #369

merged 1 commit into from
Mar 7, 2023

Conversation

johngrantuk
Copy link
Member

Fixes this issue

@johngrantuk johngrantuk requested a review from brunoguerios March 1, 2023 14:38
brunoguerios
brunoguerios approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@brunoguerios brunoguerios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be used as a simple showcase of how typescript can improve code quality 😅 👏

@johngrantuk johngrantuk merged commit c87fa4f into develop Mar 7, 2023
@johngrantuk johngrantuk deleted the fix-index-strings branch March 7, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoguerios brunoguerios brunoguerios approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johngrantuk @brunoguerios