Skip to content

Commit

Permalink
Misc fixes on LM system (#1196)
Browse files Browse the repository at this point in the history
* Remove misleading comments

Co-authored-by: Tom French <tom@tomfren.ch>
  • Loading branch information
nventuro and TomAFrench authored Mar 23, 2022
1 parent 2a1439c commit 9e5d7d2
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions pkg/liquidity-mining/contracts/AuthorizerAdaptor.sol
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,14 @@ contract AuthorizerAdaptor is IAuthorizerAdaptor, ReentrancyGuard {

/**
* @notice Returns the action ID associated with calling a given function through this adaptor
* @dev The contracts managed by this adaptor do not have action ID disambiguators we use the adaptor's globally
* @dev As the contracts managed by this adaptor don't have action ID disambiguators, we use the adaptor's globally.
* This means that contracts with the same function selector will have a matching action ID:
* if granularity is required then permissions must not be granted globally in the Authorizer.
*
* @param selector - The 4 byte selector of the function to be called using `performAction`
* @return The associated action ID
*/
function getActionId(bytes4 selector) public view override returns (bytes32) {
// Each external function is dynamically assigned an action identifier as the hash of the disambiguator and the
// function selector. Disambiguation is necessary to avoid potential collisions in the function selectors of
// multiple contracts.
return keccak256(abi.encodePacked(_actionIdDisambiguator, selector));
}

Expand Down

0 comments on commit 9e5d7d2

Please sign in to comment.