Check deployment outputs #1284
Merged
Check deployment outputs #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nventuro Can you push those extra commits from yesterday? |
TomAFrench
approved these changes
May 17, 2022
TomAFrench
added a commit
that referenced
this pull request
May 17, 2022
* master: (58 commits) Check deployment outputs (#1284) fix: use force argument in no fee LBP task (#1303) style: silence linter errors (#1302) change 'factory' to 'NoProtocolFeeLiquidityBootstrappingPoolFactory' (#1286) Double Entrypoint Fix Relayer (#1300) Singleton Authorization (#1294) Interface Refactor (#1285) Remove MultiDistributor and associated files (#1119) Add ChildChainGaugeTokenAdder contract (#1295) Split setPaused into pause/unpause (#1282) Managed Pool: comment cleanup (#1277) Managed Pool: fix test (#1278) Fix failing tests (#1293) Fix incorrect managed pool test call Fix flaky tests (#1292) Reduce managed pool tests (#1287) Fix linter errors Rename coordinator to avoid task name substring Misc deployments improvements (#1283) Add optimism support and deployments (#1279) ...
TomAFrench
added a commit
that referenced
this pull request
May 18, 2022
* master: Automatically save the deployment tx hash on deployment (#1310) Update SNX impl input (#1309) Add implementation + deployment of the ProtocolFeesWithdrawer (#1301) minor update for consistency (#1306) fix: fix fork test for NoProtocolFeeLBP (#1304) ci: switch from infura to alchemy (#1305) Check deployment outputs (#1284) fix: use force argument in no fee LBP task (#1303) style: silence linter errors (#1302) change 'factory' to 'NoProtocolFeeLiquidityBootstrappingPoolFactory' (#1286) Double Entrypoint Fix Relayer (#1300)
TomAFrench
added a commit
that referenced
this pull request
May 26, 2022
* master: (76 commits) Reuse swap fee code; add startWeights to weight update params for symmetry with swap fee update params (#1324) Ensure that global permissions are properly transferred along with root status. (#1319) Move up require to save gas on add token validation failure (#1318) Stop migrating role-admins (#1321) Managed Pools: Consistent LP allowlist behavior (#1322) Only allow root to create new granters or revokers (#1313) Only allow root to schedule a change to a delay (#1314) Switch to a two step process to migrate the root account of the Authorizer (#1316) Add optional key argument to verify-contract Add explicit getters for TimelockAuthorizer (#1298) Update Authorizer tests (#1299) fix: stop storing deployment transactions for fork test deployments (#1311) Automatically save the deployment tx hash on deployment (#1310) Update SNX impl input (#1309) Add implementation + deployment of the ProtocolFeesWithdrawer (#1301) minor update for consistency (#1306) fix: fix fork test for NoProtocolFeeLBP (#1304) ci: switch from infura to alchemy (#1305) Check deployment outputs (#1284) fix: use force argument in no fee LBP task (#1303) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #1283, tasks now have different modes. This PR adds a new mode
CHECK, which is used to verify that the addresses stored in theoutputsdirectories correspond to the build infos plus inputs. This is a work in progress, as it requires interacting with a Tenderly endpoint that is not yet public.The CHECK mode compares the data of the output contract creation transaction (which Tenderly reports) against the creation code + arguments that the task attempts to deploy. On success, it returns the previously deployed instance to support tasks that deploy multiple contracts, call functions on them, use their addresses, etc.
We will likely have to add a list of known exceptions for e.g. the relayer entrypoints, which are automatically deployed by relayer libraries.